Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kwargs not escaped in group URL #94

Open
njoyard opened this issue Jun 18, 2016 · 1 comment
Open

Kwargs not escaped in group URL #94

njoyard opened this issue Jun 18, 2016 · 1 comment

Comments

@njoyard
Copy link
Member

njoyard commented Jun 18, 2016

Example with "Group of the Greens/European Free Alliance" => should escape the slash

See http://s.yourlabs.org/sentry/lqdn/issues/3560/

@njoyard
Copy link
Member Author

njoyard commented Jun 18, 2016

I investigated for a bit and it seems django's reverse does not escape arguments (nor does the url matcher unescape them). There's quite a bit of discussion about this in ticket #22223 and it seems they don't assume the responsibility for encoding/decoding url kwargs.

So IMO we should urlencode url kwargs ourselves and decode them when used, even if I personnaly think this should be the responsibility of django.urls. What do you think @jpic ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant