Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordered identifier should have type "email" #4

Open
augjoh opened this issue Aug 2, 2021 · 1 comment
Open

Ordered identifier should have type "email" #4

augjoh opened this issue Aug 2, 2021 · 1 comment
Labels
wontfix This will not be worked on

Comments

@augjoh
Copy link

augjoh commented Aug 2, 2021

When ordering an identifier, type dns is used. An RFC8823 conformant order should have type set to email.

Please see https://datatracker.ietf.org/doc/html/rfc8823#section-3 for more information.

@polhenarejos
Copy link
Owner

This is correct. However, Certbot overrides any identifier type and always sends dns when making a new order. In particular, it uses IdentifierType.IDENTIFIER_FQDN (see certbot code). Awared of this issue, I had two options:

  • Modify Certbot. I am reluctant on forking dependencies to fit the needs. Certbot is actively maintained and having a fork only for a single line is a major effort.
  • Obviate this issue and adapt the backend. Since email-reply-00 challenge only specifies one identifier type, I adapted the backend to support dns and email identifier types when email-reply-00 is used. This is not 100% RFC compliant but it achieves the objective.

I do not know the future plans of Certbot or even email-reply-00 challenge will be supported. I hope it will, but in the meantime, I provide this temporary solution.

@polhenarejos polhenarejos added the wontfix This will not be worked on label Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants