Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TestValidation/Homogeneous_Aggregate_Validation_test_6 #33

Open
polds opened this issue Jan 9, 2024 · 0 comments
Open

Update TestValidation/Homogeneous_Aggregate_Validation_test_6 #33

polds opened this issue Jan 9, 2024 · 0 comments
Labels
tests Track test fixes from CEL -> Expr

Comments

@polds
Copy link
Owner

polds commented Jan 9, 2024

TestValidation/Homogeneous_Aggregate_Validation_test_6 is broken. We should fix or remove.

=== RUN   TestValidation/Homogeneous_Aggregate_Validation_test_6
    eval_test.go:359: Compile() got error = unexpected token Operator("?") (1:10)
         | name in [?optional.ofNonZeroValue(''), 'hello', ?optional.of('')]
         | .........^, wantErr false
    --- FAIL: TestValidation/Homogeneous_Aggregate_Validation_test_6 (0.00s)
@polds polds added the tests Track test fixes from CEL -> Expr label Jan 9, 2024
polds added a commit that referenced this issue Jan 10, 2024
athegaul pushed a commit that referenced this issue Jan 10, 2024
* Add a test that passes on the playground, but stil doesn’t pass in the test. Needs more investigation

ref: #5

* fix #6

* Fix #7

* Fix #8

* FIx #21

* Fixes #22, #23, #24, #25, #26, #27, #28, #29, #30, #31, #33, #34, #35

* Update comments and fix duration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Track test fixes from CEL -> Expr
Projects
None yet
Development

No branches or pull requests

1 participant