Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): Changed mapping type from dict to Mapping (#19400) #19436

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(python): Changed mapping type from dict to Mapping (#19400) #19436

wants to merge 1 commit into from
+14 −2

Conversation

DavideCanton
Copy link

Resolves #19400

@DavideCanton DavideCanton changed the title feat: changed mapping type from dict to Mapping (#19400) feat(python): Changed mapping type from dict to Mapping (#19400) Oct 24, 2024
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars and removed title needs formatting labels Oct 24, 2024
@DavideCanton
Copy link
Author

It seems that the check failing is unrelated to my changes, is it a flaky test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generalize the type of the input to rename from dict to mapping
1 participant
@DavideCanton