From 0601b5ef4f626aceb36c6c8ef17eb4d6c0916783 Mon Sep 17 00:00:00 2001 From: Mohammad Amer Date: Wed, 23 Oct 2024 19:47:20 +0300 Subject: [PATCH] Updated node version to node 18 --- samples/react-datatable/.devcontainer/devcontainer.json | 4 ++-- samples/react-datatable/.nvmrc | 2 +- samples/react-datatable/.yo-rc.json | 2 +- samples/react-datatable/assets/sample.json | 4 ++-- samples/react-datatable/package.json | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/samples/react-datatable/.devcontainer/devcontainer.json b/samples/react-datatable/.devcontainer/devcontainer.json index 896564300e..73c1edb937 100644 --- a/samples/react-datatable/.devcontainer/devcontainer.json +++ b/samples/react-datatable/.devcontainer/devcontainer.json @@ -1,7 +1,7 @@ // For more information on how to run this SPFx project in a VS Code Remote Container, please visit https://aka.ms/spfx-devcontainer { - "name": "SPFx 1.14.0", - "image": "docker.io/m365pnp/spfx:1.14.0", + "name": "SPFx 1.20.0", + "image": "docker.io/m365pnp/spfx:1.20.0", // Set *default* container specific settings.json values on container create. "settings": {}, // Add the IDs of extensions you want installed when the container is created. diff --git a/samples/react-datatable/.nvmrc b/samples/react-datatable/.nvmrc index 593cb75bc5..34bfa5c695 100644 --- a/samples/react-datatable/.nvmrc +++ b/samples/react-datatable/.nvmrc @@ -1 +1 @@ -20.16.0 \ No newline at end of file +18.19.1 \ No newline at end of file diff --git a/samples/react-datatable/.yo-rc.json b/samples/react-datatable/.yo-rc.json index 1418b72655..e1fc600689 100644 --- a/samples/react-datatable/.yo-rc.json +++ b/samples/react-datatable/.yo-rc.json @@ -1,7 +1,7 @@ { "@microsoft/generator-sharepoint": { "@microsoft/generator-sharepoint": { - "nodeVersion": "20.16.0" + "nodeVersion": "18.19.1" }, "sdksVersions": { "@microsoft/microsoft-graph-client": "3.0.2", diff --git a/samples/react-datatable/assets/sample.json b/samples/react-datatable/assets/sample.json index 8ebb627c34..41e13ee4de 100644 --- a/samples/react-datatable/assets/sample.json +++ b/samples/react-datatable/assets/sample.json @@ -9,7 +9,7 @@ "This web part provides easy way to render SharePoint custom list in data table view with all the necessary features." ], "creationDateTime": "2021-03-01", - "updateDateTime": "2022-11-01", + "updateDateTime": "2024-10-20", "products": [ "SharePoint" ], @@ -20,7 +20,7 @@ }, { "key": "SPFX-VERSION", - "value": "1.14.0" + "value": "1.20.0" }, { "key": "PNPCONTROLS", diff --git a/samples/react-datatable/package.json b/samples/react-datatable/package.json index e1cca022c3..c59aa0446c 100644 --- a/samples/react-datatable/package.json +++ b/samples/react-datatable/package.json @@ -3,7 +3,7 @@ "version": "1.6.0", "private": true, "engines": { - "node": ">=18.17.1 <19.0.0" + "node": ">=16.13.0 <17.0.0 || >=18.17.1 <19.0.0" }, "main": "lib/index.js", "scripts": {