Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample missing README details: react-application-news-ticker #479

Open
sympmarc opened this issue Jun 15, 2022 · 5 comments
Open

Sample missing README details: react-application-news-ticker #479

sympmarc opened this issue Jun 15, 2022 · 5 comments
Labels
sample:react-application-news-ticker type:enhancement New feature or enhancement of existing capability

Comments

@sympmarc
Copy link

Sample

https://github.com/pnp/sp-dev-fx-extensions/tree/main/samples/react-application-news-ticker

Author(s)

@sudharsank

Suggestion

The README for this sample seems to just be the template - no details are provided.

Are you willing to help?

Yes

@sympmarc sympmarc added Needs: Triage 🔍 type:enhancement New feature or enhancement of existing capability labels Jun 15, 2022
@ghost
Copy link

ghost commented Jun 15, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@sympmarc
Copy link
Author

I tried to build this for @teylyn yesterday and couldn't figure it out. No docs means I have to read the code to see what's it's supposed to do. :(

@teylyn
Copy link

teylyn commented Jun 17, 2022

Hello @sudharsank , I have this app working in the gulp serve preview, but when I package and deploy to a site collection app catalog, then add the app to the site, nothing happens on the modern site pages. What should be done?

@Rampriyar2022
Copy link

Rampriyar2022 commented Jul 13, 2022

Same here, The app doesn't work and no details on how to fix it! I followed the same procedure but after the deployment nothing happens, @sudharsank can you please help?

@AriGunawan
Copy link
Contributor

It seems that the last update (upgrade SPFx version to 1.14) didn't correctly implemented (missed readme, missed modules (react, react-dom, types, etc), changed ids, etc).
I've recreated the app using the latest SPFx and tested + deployed the app and created a PR.
Hope the app works again for you.
*Please reinstall the app from fresh folder to make sure that you install the latest version (after my PR has been merged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sample:react-application-news-ticker type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

5 participants