Fourth incremental upgrade to SPFx v1.16.1 #1424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NishkalankBezawada
changed the title
NishkalankBezawada
changed the title
NishkalankBezawada
changed the title
NishkalankBezawada
changed the title
|
Hi @Adam-it This project uses 
So far, I have upgraded it until SPFx v1.16.1 Thanks, |
Adam-it
requested changes
Oct 30, 2024
There was a problem hiding this comment.
@NishkalankBezawada I had a quick glance at the PR.
I am wondering if it is ok we are commenting out so much code and changing the behavior of the sample 🤔?
Could we have a double check on some of the comments I left? 🙏
samples/react-command-print/src/extensions/print/PrintCommandSet.ts
Outdated
Show resolved
Hide resolved
...-command-print/src/extensions/print/components/print-dialog-content/print-dialog-content.tsx
Show resolved
Hide resolved
samples/react-command-print/src/extensions/print/util/list-helper.ts
Outdated
Show resolved
Hide resolved
|
Hey @Adam-it here you go, with the comments and resolutions. I send you back this PR for review :) I have checked it again by serving the extension, it works good.
Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Tried to upgrade the SPFx v1.7.0 to SPFx v1.20.0, but this project seems to have dependencies which will not work with react v17. I would like to give a try to upgrade to spfx v1.11.0 since, later versions of spfx has a significant breaking changes too. This might take some time, but I suggest to upgrade to spfx v1.11.0 and then try to do an incremental upgrade.
So this PR contains first incremental SPFx upgrade to SPFx v1.111.0
Thanks,
Nishkalank