Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fontello files not found when site is not on domain root #68

Open
ewohnlich opened this issue Feb 27, 2020 · 1 comment
Open

Fontello files not found when site is not on domain root #68

ewohnlich opened this issue Feb 27, 2020 · 1 comment

Comments

@ewohnlich
Copy link

plone-compiled.css has a font-face declaration with src declarations along these lines: src:url('/../++plone++static/fonts/plone-fontello.eot') This will try to find ++plone++static on the root of the domain but we normally have sites on some path, e.g. foobar.com/plone as the site root.

I don't actually notice any odd behavior on sites - for instance the toolbar icons, which I think are this fontello font, still appear. It looks like it may be using an embedded font instead?

@yurj
Copy link
Contributor

yurj commented Nov 10, 2021

I confirm the bug, happens to me. Any workaround?

The problem is here:

https://github.com/plone/plone.staticresources/blob/134188c0afe6dc5ff69ddac9e1c74c3a3ab08835/src/plone/staticresources/static/plone-fontello.less

@fontsPrefix: '/++plone++static/fonts/';
@import url("fonts/plone-fontello.less");

this should be @fontsPrefix: '++plone++static/fonts/'; (without the first /).

It is used here:
https://github.com/plone/plone.staticresources/blob/134188c0afe6dc5ff69ddac9e1c74c3a3ab08835/src/plone/staticresources/static/fonts/plone-fontello.less (note the static/fonts/plone-fontello.less and not static/plone-fontello.less)

@font-face {
  font-family: 'fontello';
  src: url('@{fontsPrefix}plone-fontello.eot?89786008');

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants