-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
citation not formated at all (blockquote)( oder so ähnlich()) #4063
Comments
[EDIT] there may be opinions on how to format a citation/blockquote, but it should not be ignored completely IMHO. |
I'd suggest pulling the style from Bootstrap for blockquote: https://getbootstrap.com/docs/5.3/content/typography/#blockquotes. @ksuess thanks for reporting. If you don't have time to work on it, perhaps someone from the @plone/classicui-team can add information here about which package needs to be updated and how, to help this issue move forward. |
something like
? |
hm ... blockquote {
@extend .blockquote; // font-size and margin
background: var(--bs-light-bg-subtle);
border-left: var(--bs-border-style) 5px var(--bs-border-color);
color: var(--bs-light-text-emphasis);
padding: $spacer;
} leads to something like this: note that using the variables ensures the correct coloring for light and dark mode (see https://classic.demo.plone.org/@@test-rendering-cheatsheet) EDIT: you can simulate that with this snippet in the demo page: <blockquote class="blockquote border-start border-5 p-3 bg-light-subtle text-light-emphasis">
<p>Bearbeiten Sie diese Seite und testen Sie Plone jetzt!</p>
</blockquote>
<blockquote class="blockquote border-start border-5 p-3 bg-light-subtle text-light-emphasis" data-bs-theme="dark">
<p>Bearbeiten Sie diese Seite und testen Sie Plone jetzt!</p>
</blockquote> |
Great to see the comeback of the |
Well, no. According MDN: The blockquote HTML element indicates that the enclosed text is an extended quotation. |
I agree with @ksuess about the display. I might also want to include a However, I am hesitant to include quotation marks, as there are different kinds of quotation marks depending on the language. References: |
https://html.spec.whatwg.org/multipage/grouping-content.html#the-blockquote-element Where do you read it? |
Following this conversation, I think the reason why blockquote in Plone is not formatted, is that different countries and languages have different rules or different common ways to handle.
My CSS for swiss german will look like this:
|
Yes, a |
OK I get the point of I suggest to implement the quotes as variables in barceloneta, so one can change this in his project:
and use it in barceloneta like
Nice to know: since css-nesting (https://caniuse.com/css-nesting) modern browsers would compile the notation above without the need of scss compiling. |
two solutions for
|
I really appreciate the the time you are investing, @petschki. I think this is an enhancement to the current situation, even if for a project, the theme variables need to be set according language and country. And for a multilingual site there are more CSS rules to be added. |
IIRC those |
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/blockquote
The <blockquote> [HTML](https://developer.mozilla.org/en-US/docs/Web/HTML) element indicates that the enclosed text is an extended quotation.
go to https://classic.demo.plone.org/en
I expect blockquote nodes to be formatted somehow. there may be opinions on how to format a citation/blockquote, but it should not be ignored completely IMHO.
The text was updated successfully, but these errors were encountered: