Submission schema getReviewRoundsFromSubmission() overridden in OMP can cause regression

[Vitaliy-1]

Describe the bug
lib/pkp has submission schema has method Schema::getReviewRoundsFromSubmission(), which returns the collection of Review Rounds:

pkp-lib/classes/submission/maps/Schema.php

Line 866 in 3f903cb

protected function getReviewRoundsFromSubmission(Submission $submission): Collection

It's overridden in OMP: https://github.com/pkp/omp/blob/main/classes/submission/maps/Schema.php#L127, where it returns a 2-dimensional collection of Review Rounds, which affects the code that is executed in the the shared library.

This issue partially fixes the direct cause of the problem: #10851 but it might not taking into account additional logic, e.g., is there a need to retrieve grouped review rounds in the shared library as well or should it be used only in OMP?

@taslangraham, you are probably now the best if anything should be done here. Could you take a look?

What application are you using?
OMP

[taslangraham]

On review, the overridden getReviewRoundsFromSubmission() method shouldn't have been returning a 2D collection of Review Rounds in the first place - it was just flattened and sorted before use anyways. That change was initially made as a fix for this issue. The temporary fix was good, however the base getReviewRoundsFromSubmission() method is still used in Schema::mapByProperties() in submission for pkp-lib to get review rounds then fetch stages data(which is where the previous error was popping up, due to the 2D collection).

pkp-lib/classes/submission/maps/Schema.php

Lines 398 to 402 in 80ca552

	$reviewRounds = $this->getReviewRoundsFromSubmission($submission);
	$currentReviewRound = $reviewRounds->sortKeys()->last(); /** @var ReviewRound|null $currentReviewRound */
	$stages = in_array('stages', $props) ?
	$this->getPropertyStages($this->stageAssignments, $submission, $this->decisions ?? null, $currentReviewRound) :
	[];

But as reported in this issue, the implementation of getReviewRoundsFromSubmission() in shared library doesn't properly handle external and internal review rounds for OMP.

I've added a PR to properly sort, and make the results 1-dimensional in the overridden implementation of getReviewRoundsFromSubmission() in OMP, ensuring consistent data and that the results are what pkp-lib expects. No changes are needed in OPS or OJS

PR
omp - https://github.com/pkp/omp/pull/1820/files