Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesigned Dashboard & Workflow - Identifiers #10821

Open
jardakotesovec opened this issue Jan 18, 2025 · 4 comments
Open

Redesigned Dashboard & Workflow - Identifiers #10821

jardakotesovec opened this issue Jan 18, 2025 · 4 comments
Assignees
Milestone

Comments

@jardakotesovec
Copy link
Contributor

jardakotesovec commented Jan 18, 2025

Pkp maintains urn plugins for Identifiers section. Using this as placeholder to make sure that this plugin is properly updated and tested for 3.5.

Ready for testing, some notes from @bozana for testing:

The work on URN is merged and here are some information about URNs and what would be good to test:
URN PubId Plugin needs to be enabled. It works similar to how DOI PubId Plugin works in 3.3. (in 3.4. DOIs got refactured).

The plugin needs to be enabled.

Plugin settings:
The major plugin settings are similar to the DOI's ones. Here is documentation for the DOI plugin in 3.3. https://docs.pkp.sfu.ca/doi-plugin/en/doi-plugin.
In the settings you define what objects the URNs need to be assigned to: issues, articles (publications), galleys.
You need to enter the prefix. For testing you can add "urn:nbn:de:0000-".
The way the suffix is created needs to be defined: default method, manually entered suffixes, using custom patterns.
If the check number is needed. For German Digital Library this is required, for example. It is an algorithm that calculates a check number based on the URN suffix. The check number is then added at the end, as the last number for the URN.
Namespace needs to be defined, where the URNs will be registered. (Currently not used in core, just in some external plugins that export and register URNs to a national library).
Resolver URL: where URNs can be resolved (to an URL).

The URNs can then be assigned when editing an object (issue, publication, or galley -- depending on the settings). For issue and galley, there is the "Identifier" tab in the edit modal. For publication it is a menu item, appearing below the "Metadata" menu item. Depending on the art of suffixes, defined in plugin settings, the URNs are differently assigned. Also the UI/design for publication object is slightly different from issues and galleys.

URNs are then displayed on the right side on the article view page, and on the issue TOC page. I think the galley URNs are not displayed at all 😕

I would suggest to test all possible settings: all objects, all ways the suffixes can be assigned (maybe above all the custom patterns, that we rarely test), and the check number (with and without it). Also to try to create duplicate URNs for the same object type would be good to test, i.e. to try that two articles have totally same URN string -- an error message should appear.

You could also test the "Reassign URNs" button in the plugin settings: After you assigned a few URNs, change the prefix or suffix, press the button and see if the assigned ones are cleared/removed and the new settings applied.

PR links (all merged):
PRs (some fixes for URNs, update pubIds plugin for vue3):

jardakotesovec added a commit to pkp/ojs that referenced this issue Jan 20, 2025
bozana added a commit to bozana/pkp-lib that referenced this issue Jan 20, 2025
bozana added a commit to bozana/ojs that referenced this issue Jan 20, 2025
bozana added a commit to bozana/ojs that referenced this issue Jan 20, 2025
bozana added a commit to bozana/pkp-lib that referenced this issue Jan 20, 2025
bozana added a commit to bozana/ojs that referenced this issue Jan 20, 2025
bozana added a commit to bozana/omp that referenced this issue Jan 20, 2025
…ply Number in URN plugin, disable for empty value
bozana added a commit to bozana/omp that referenced this issue Jan 20, 2025
bozana added a commit that referenced this issue Jan 20, 2025
#10821 fix checkDuplicate, changePubId, pubIdExists, publi…
bozana added a commit to pkp/ojs that referenced this issue Jan 20, 2025
 pkp/pkp-lib#10821 fix checkDuplicate, anyPubIdExists, pubIdExists, syntax fix for FieldTextUrn.js
bozana added a commit to pkp/omp that referenced this issue Jan 20, 2025
pkp/pkp-lib#10821 Migrate pubid plugin to vue3, Use pkp-button for Apply Number in URN plugin, disable for empty value, Fix anyPubIdExists, pubIdExists, checkDuplicate
@jardakotesovec jardakotesovec added this to the 3.5.0 LTS milestone Jan 26, 2025
@Tribunal33
Copy link

Hello @jardakotesovec and @bozana I have a few issues/questions

First is for the configuration layout. I see some issues and would make a suggestion. Here is a comparison of 3.4 vs 3.5. They are not aligned. Can we fix this and also stack these please?

Image

Second is the error message for URN prefix doesn't render correctly but is duplicated and renders at the top of the page? Is expected?

Image

It also has a Global error handling message that isn't rendered correctly
Image

And is it expected that there is no pattern matching for these fields? They can be saved? It might even trigger the above global error handling message but still saves.

Image

@Tribunal33
Copy link

Tribunal33 commented Jan 31, 2025

Third, @bozana Could you clarify a few things for me?

Check number: I know we don't use it in core functionality but what are the options in the dropdown referencing and will it affect any URNs i'm checking?

Resolver URL : Could you give me an example of one that I can use for testing purposes. I selected https://nbn-resolving.de/ but I'm worried that my local environment might annoy this site?

I'm trying to find where it is located. I do not see it in the article view page or issue TOC page. These are the site wide pages
/index.php/publicknowledge/en/issue/view/1 AND /index.php/publicknowledge/en/article/view/17 , correct?

When you are inside the published submission and you have created an URN, if you were to create a new version would that URN have to be changed or would that URN remain with the publication? And since a submission needs to be assigned to an issue before an URN can be created what would be expected if I change the issue or removed it (if possible)? Currently, you could assign to issue number 1 then create an URN then change issue to number 2 and URN is gone. I'm talking about this area

Image

@Tribunal33
Copy link

Fourth @jardakotesovec I'm seeing this error in the apache logs on Galleys when I try to open the identifiers tab

[client ::1:49849] PHP Fatal error: Uncaught Error: Call to a member function getJournalId()

Image

@asmecher
Copy link
Member

asmecher commented Feb 1, 2025

@Tribunal33, on this one...

PHP Fatal error: Uncaught Error: Call to a member function getJournalId()

...can you include the rest of the PHP error message from the server log? There should be a filename and line number, for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants