Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PHP scripts with R or Java #578

Open
nichtich opened this issue Jan 31, 2025 · 0 comments
Open

Replace PHP scripts with R or Java #578

nichtich opened this issue Jan 31, 2025 · 0 comments
Labels
partner:vzg Feature request from VZG

Comments

@nichtich
Copy link
Collaborator

The source contains some of PHP, mainly for simple tasks:

wc -l $(git ls-files | grep .php)
  228 scripts/cli-generator/generate.php
   46 scripts/shelf-ready/shelf-ready-histogram.php
   32 scripts/sqlite/normalize-issue-details.php
   54 scripts/sqlite/solr-copy-ids-from-validation.php
  113 scripts/sqlite/validation-result-indexer-grouped.php
   64 scripts/sqlite/validation-result-indexer-simple.php
   46 scripts/tt-histogram/tt-histogram.php
   62 scripts/utils/parameter-filter.php
  645 total

Compared to 2.562 lines of Shell, 2.637 lines of R 118.459 lines of Java this is little, so rewriting in one of these languages seems doable to improve maintability and code quality (Java is already covered by tests/code analysis but R, Shell and PHP is not).

@nichtich nichtich added the partner:vzg Feature request from VZG label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partner:vzg Feature request from VZG
Projects
None yet
Development

No branches or pull requests

1 participant