Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: fix duplicate file seq #11987

Closed
wants to merge 6 commits into from
Closed

storage: fix duplicate file seq #11987

wants to merge 6 commits into from

Conversation

lidezhu
Copy link
Collaborator

@lidezhu lidezhu commented Jan 7, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #11979

What is changed and how it works?

When enable-partition-separator is false, use logical table id to manage file index.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Fix partition table data lost when sink type is cloud storage and enable-partition-separator is false.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 7, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lidezhu, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 7, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.2054%. Comparing base (99e00c0) to head (9422fb2).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
cdc ∅ <ø> (∅)
dm ∅ <ø> (∅)
engine 53.2054% <ø> (-0.0283%) ⬇️
Flag Coverage Δ
unit 53.2054% <ø> (-2.0708%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11987        +/-   ##
================================================
- Coverage   55.2761%   53.2054%   -2.0708%     
================================================
  Files          1004        213       -791     
  Lines        137761      17720    -120041     
================================================
- Hits          76149       9428     -66721     
+ Misses        56046       7689     -48357     
+ Partials       5566        603      -4963

@lidezhu lidezhu closed this Jan 7, 2025
@lidezhu lidezhu deleted the fix-duplicate-file-seq branch January 7, 2025 13:40
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2025 •
edited
Loading

@lidezhu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-verify bd8567d link true /test pull-verify
pull-cdc-integration-mysql-test bd8567d link true /test pull-cdc-integration-mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

disable the config enable-partition-separator
1 participant
@lidezhu