Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript bundle details #3

Open
adamchainz opened this issue Nov 14, 2024 · 2 comments
Open

JavaScript bundle details #3

adamchainz opened this issue Nov 14, 2024 · 2 comments

Comments

@adamchainz
Copy link

Hi!

Thanks for building this tool. I'm evaluating it for a client.

I browsed the repository to figure out how the charting is done, and found the JS bundle file, main.62427c30.js, but no source for it. I am suspicious about launching a giant blob of JS on my client's sensitive site with no visibility into what it does. It would be great if the source were provided.

Furthermore, there's no info on the underlying charting library. The bundle file starts with:

/*! For license information please see main.62427c30.js.LICENSE.txt */

…but that file is missing.

It looks like drawio is the library, which has a CC BY 4.0 license, meaning there must be a named link to Draw.io visible.

Thank you!

@pikhovkin
Copy link
Owner

@adamchainz Thank you for your interest in the project!
I don't plan to open source of js-bundle in the near future.
js-bundle is based on open source libraries.
The bundle contains an xml-template for generating a diagram file that can be opened in draw.io.

@piranna
Copy link

piranna commented Dec 1, 2024

If you don't open source the js-bundle and offer It as a blob, then the project can't be published with MIT license. I think It should be generated from source code files at install time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants