lack of color in some plots

[orichters]

Dear colleagues, I have a strange bug. Using piamInterfaces::plotIntercomparison which calls mip::showLinePlots, I get the following document, which has nice and colorful plots, except for the Nationally Determined Contributions (NDCs) scenario. Anyone an idea, why?

[orichters]

The problem seems to be related to the () in the scenario title. No idea what is going on, though.

[orichters]

The reason:
color_set <- plotstyle(sources) in mipLineHistorical(), but plotstyle() says: "Units in brackets "(US$2005/GJ)" will be ignored", which it seems to do in this line.

Consequence:

> sources
[1] "GCAM 5.3+ NGFS.Nationally Determined Contributions (NDCs)"             
[2] "MESSAGEix-GLOBIOM 1.1-M-R12.Nationally Determined Contributions (NDCs)"
[3] "REMIND-MAgPIE 3.0-4.4.Nationally Determined Contributions (NDCs)"      
> plotstyle(sources)
             GCAM 5.3+ NGFS.Nationally Determined Contributions 
                                                      "#e6194B" 
MESSAGEix-GLOBIOM 1.1-M-R12.Nationally Determined Contributions 
                                                      "#3cb44b" 
      REMIND-MAgPIE 3.0-4.4.Nationally Determined Contributions 
                                                      "#4363d8"

and this line in mipLineHistorical is unable to match colors to models, and makes everything grey.

So: it is a bug. I have no idea how to proceed, given all these dependencies of these functions.

I think a safe solution without many possible side-effects would be to replace this line by something that also strips away all the ( stuff. Or use unitsplit everywhere.

Solutions warmly welcome @tscheypidi @dklein-pik

[orichters]

Ah, I see. Basically the same problem as in #54