Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate and retain "blockified" version of trigger in dedicated property #278

Open
tsalo opened this issue Jul 26, 2020 · 1 comment
Open
Labels
Enhancement New feature or request

Comments

@tsalo
Copy link
Member

tsalo commented Jul 26, 2020

Detailed Description

This issue stems from @smoia's comment in #219 (comment). Essentially, the BIDS-synchronized run labeling and splitting workflow in #219 requires onsets of physio runs before the workflow is called (durations are useful for visualization, but not necessary). General splitting would also benefit from having a binarized version of the trigger, with any signal variability averaged over the course of each run, in order to identify the onset and duration of each run.

Context / Motivation

This is useful, and perhaps necessary, for the workflow in #219, but also is helpful for splitting runs regardless of general workflow, as the run onsets and offsets are the basic information needed for the task.

Possible Implementation

I don't know. For natively block-like triggers like mine, this is a non-issue, but I'm hoping that the rest of the devs have a good way of determining run onsets and offsets for variable triggers that can be applied here.

@tsalo tsalo added the Enhancement New feature or request label Jul 26, 2020
@smoia
Copy link
Member

smoia commented Oct 8, 2020

@physiopy/phys2bids does anyone wants to help with this issue in order to unblock #219?

Ideas are welcome!

I think we can apply something similar to BlueprintInput.check_trigger_amount - maybe even that same function, expanded a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants