Floki.HTMLParser.FastHtml fails to parse <noscript> properly when present in head. #580

arun-muthuraman · 2024-07-02T09:38:51Z

Description

When there is a noscript tag with content present in the head, when parsed, FastHtml moves all the tags present after noscript and the children of noscript into the body node. There is no issue if the noscript tag is present inside the body.

To Reproduce

Steps to reproduce the behavior:

Using Floki v0.35.2
Using Elixir v1.15.7
Using Erlang OTP 26
With this code:

 test_html =
  """
  <html>
   <head>
     <noscript><a href='/test'>link</a></noscript>
     <title>test</title>
   </head>
   <body>
     <noscript><a href='/test'>link</a></noscript>
     <p>test p</p>
   </body>
  </html>
  """

Floki.parse_document!(test_html, html_parser: Floki.HTMLParser.FastHtml)

[
  {"html", [],
   [
     {"head", [], ["\n   ", {"noscript", [], []}]},
     {"body", [],
      [
        {"a", [{"href", "/test"}], ["link"]},
        "\n   ",
        {"title", [], ["test"]},
        "\n \n \n   ",
        {"noscript", [], [{"a", [{"href", "/test"}], ["link"]}]},
        "\n   ",
        {"p", [], ["test p"]},
        "\n \n\n"
      ]}
   ]}
]

Expected behavior

[
{"html", [],
 [
   {"head", [],
    [
      "\n",
      {"noscript", [],
       [{"a", [{"href", "/link"}], ["link text"]}]},
      {"title", [], ["test"]},
      "\n"
    ]},
   "\n",
   {"body", [],
    [
      "\n",
      {"noscript", [],
       [{"a", [{"href", "/link"}], ["link text"]}]},
      "\n",
      {"p", [], ["test p"]},
      "\n\n\n"
    ]}
 ]}
]

arun-muthuraman added the Bug label Jul 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Floki.HTMLParser.FastHtml fails to parse <noscript> properly when present in head. #580

Floki.HTMLParser.FastHtml fails to parse <noscript> properly when present in head. #580

arun-muthuraman commented Jul 2, 2024 •

edited

Loading

Floki.HTMLParser.FastHtml fails to parse <noscript> properly when present in head. #580

Floki.HTMLParser.FastHtml fails to parse <noscript> properly when present in head. #580

Comments

arun-muthuraman commented Jul 2, 2024 • edited Loading

Description

To Reproduce

Expected behavior

arun-muthuraman commented Jul 2, 2024 •

edited

Loading