Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(confluence): remove divider from ConfluenceResultListItem #221

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

benjidotsh
Copy link
Contributor

This PR removes the divider from ConfluenceResultListItem since it acts as a duplicate divider. Especially if you have applied any sort of formatting, like we have, this can look really bad.

Before:

Scherm­afbeelding 2024-11-15 om 16 03 14

After:

Scherm­afbeelding 2024-11-15 om 16 13 21

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Screenshots attached (for UI changes)

@philips-backstage-plugins-bot

Changed Packages

Package Name Package Path Changeset Bump Current Version
@philips-software/backstage-plugin-search-confluence-frontend workspaces/confluence/plugins/search-confluence-frontend patch v2.2.0

Copy link
Member

@Prateek-Wayne Prateek-Wayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
It Looks Better now

@ScottGuymer ScottGuymer merged commit 1ea8359 into philips-software:main Nov 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants