Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #79

Open
1 task done
philipmat opened this issue Feb 24, 2017 · 4 comments · May be fixed by #123
Open
1 task done

Windows support #79

philipmat opened this issue Feb 24, 2017 · 4 comments · May be fixed by #123
Milestone

Comments

@philipmat
Copy link
Owner

philipmat commented Feb 24, 2017

TODO for Windows support:

  • get_latest_dumps - change to python and have it produce the list of URLs for wget (should not require any libraries outside the base python modules)

Downloading files with requests: https://stackoverflow.com/questions/16694907/download-large-file-in-python-with-requests

@pfouque
Copy link

pfouque commented Feb 24, 2017

I was thinking to something like that.
Perhaps also downloading with python.
Or we can stream content directly.

@philipmat
Copy link
Owner Author

@pfouque @ijabz - would you mind testing the get_dumps_xplatform branch?

I'm looking for feedback on python 2 and 3 on MacOS and Linux.

@pfouque
Copy link

pfouque commented Feb 24, 2017

It seems to work fine but I have some concerns about deleting actual shell file. Perhaps you should keep it ( and update it) to avoid introducing a breaking change.

@philipmat
Copy link
Owner Author

Thanks @pfouque - I really appreciate it. As far get_latest_dumps.sh, as I mentioned in my comment to your code review (thanks for it, btw!)

In the interest of keeping with the Zen of Python, I prefer that there'd be only one way of doing it. I don't want to keep two scripts when one, which is also cross-platform, is enough; it increases both confusion and maintenance.

@philipmat philipmat added this to the v1.5 milestone Feb 24, 2017
@philipmat philipmat modified the milestones: v1.5, v2.0 Aug 15, 2020
@philipmat philipmat mentioned this issue Aug 18, 2020
2 tasks
@philipmat philipmat modified the milestones: v2.0, v2.1 Aug 18, 2020
@philipmat philipmat modified the milestones: v2.1, v2.2 Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants