Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change title for Pinboard link detail pages? #224

Closed
philgyford opened this issue Oct 12, 2021 · 2 comments
Closed

Change title for Pinboard link detail pages? #224

philgyford opened this issue Oct 12, 2021 · 2 comments

Comments

@philgyford
Copy link
Owner

At the moment they're just "A link", e.g. https://www.gyford.com/phil/links/philgyford/09f7331ead5e/ which isn't great in <title> or when sharing on Twitter etc. Not sure what else to make it. Add a short version of the link's title?

@garrettc
Copy link
Contributor

I like the way Daring Fireball handles this, the title is the link, but in the feed it also includes a permalink to the entry on the local site (an example).

(I'm currently rebuilding my own site and I'm integrating django-ditto to gather up all my bits from all the various other sites, I'm very excited about what you've built here and hope to be able to contribute)

@philgyford
Copy link
Owner Author

For some better context (and to remind me, because I'd forgotten what ways the templates on gyford.com differ from the Ditto defaults), here's a screenshot using bookmark_detail.html template:

Screenshot 2021-10-22 at 16 48 06

and out of interest, one using bookmark_list.html template:

Screenshot 2021-10-22 at 16 49 24

My only reservation about using the <title> of the linked-to page is that (as here) it can be very long. We could limit it to a certain number of characters, ending with .... Either would be better than the current practise where every Bookmark Detail page has the same title of "Pinboard bookmarklet by ".

(Welcome aboard!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants