Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UtteranceQueue implementAsSkeleton is an anti-pattern #26

Open
zepumph opened this issue Aug 12, 2021 · 1 comment
Open

UtteranceQueue implementAsSkeleton is an anti-pattern #26

zepumph opened this issue Aug 12, 2021 · 1 comment

Comments

@zepumph
Copy link
Member

zepumph commented Aug 12, 2021

While working on #17, I'm pretty sure that we could get rid of this confusing implementation detail in UtteranceQueue (a remnant of baseline API files for PhET-iO). I don't think there is anything checking the runtime against what is expected to be in it. This shouldn't even be an API change, since the sims being published with description are the only ones that should have an UtteranceQueue.

@zepumph zepumph self-assigned this Aug 12, 2021
@zepumph
Copy link
Member Author

zepumph commented Aug 12, 2021

@jessegreenberg mentioned that we can't do this until there aren't any more usages that use the global pattern like

phet.joist.sim.display.utteranceQueue, because in some common code that may be called when not in a description-supported runtime.

@zepumph zepumph removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants