Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should be disposed for web audio? #118

Open
zepumph opened this issue Jul 27, 2020 · 0 comments
Open

What should be disposed for web audio? #118

zepumph opened this issue Jul 27, 2020 · 0 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Jul 27, 2020

This issue comes from my working in Ratio and Proportion.

The immediate bug is that SoundClip.dispose doesn't stop a sound, such that it is possible when you switch sound options in RaP "in proportion" sounds (which are quite long), to hear the tail end of the last while the next one is playing.

In practice this won't be an issue, but it made me think about sound disposal, and got me poking around in SoundGenerator.dispose.

Questions for this issue:

  • Is there are web audio "connections" that should be broken as part of SoundGenerator.dispose()? Perhaps disconnecting the masterGainNode, or clearing the connectionList.
  • SoundClip.stop() seems like an obvious thing to add into a SoundClip.dispose(), what do you think?
  • Is there anything else to this topic?

Again, the only issue I see in Ratio and Proportion is from having options (which won't be in the production version). So this doesn't need a high priority to it or anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants