You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue comes from my working in Ratio and Proportion.
The immediate bug is that SoundClip.dispose doesn't stop a sound, such that it is possible when you switch sound options in RaP "in proportion" sounds (which are quite long), to hear the tail end of the last while the next one is playing.
In practice this won't be an issue, but it made me think about sound disposal, and got me poking around in SoundGenerator.dispose.
Questions for this issue:
Is there are web audio "connections" that should be broken as part of SoundGenerator.dispose()? Perhaps disconnecting the masterGainNode, or clearing the connectionList.
SoundClip.stop() seems like an obvious thing to add into a SoundClip.dispose(), what do you think?
Is there anything else to this topic?
Again, the only issue I see in Ratio and Proportion is from having options (which won't be in the production version). So this doesn't need a high priority to it or anything.
The text was updated successfully, but these errors were encountered:
This issue comes from my working in Ratio and Proportion.
The immediate bug is that SoundClip.dispose doesn't stop a sound, such that it is possible when you switch sound options in RaP "in proportion" sounds (which are quite long), to hear the tail end of the last while the next one is playing.
In practice this won't be an issue, but it made me think about sound disposal, and got me poking around in
SoundGenerator.dispose
.Questions for this issue:
SoundGenerator.dispose()
? Perhaps disconnecting themasterGainNode
, or clearing theconnectionList
.Again, the only issue I see in Ratio and Proportion is from having options (which won't be in the production version). So this doesn't need a high priority to it or anything.
The text was updated successfully, but these errors were encountered: