Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use findStringProperty to automatically discover accessible names #911

Open
jessegreenberg opened this issue Nov 6, 2024 · 3 comments
Open
Assignees

Comments

@jessegreenberg
Copy link
Contributor

In phetsims/scenery#1526, a utility function was added that can find string Properties under a Node. Called PDOMUtils.findStringProperty. It can be used to set default accessible names for common code components.

This issue is to review components in sun, scenery-phet, and other common code components and use this utility function to implement good defaults for accessible names.

Related to #901.

@jessegreenberg
Copy link
Contributor Author

jessegreenberg commented Nov 7, 2024

We are going to try using this to support MOTHA. Here is a list of components that we should start with for this work.

phetsims/models-of-the-hydrogen-atom#82 (comment)

@jessegreenberg
Copy link
Contributor Author

jessegreenberg commented Nov 8, 2024

Doing this in ComboBox will be a bit tricker because of changes for #865. I have asked if we can remove some of that code. In the meantime I'll work on other components.

EDIT: Confirmed that it is OK to remove this code. That will clean up ComboBox and make it easier to implement this issue.

@jessegreenberg
Copy link
Contributor Author

The above commits handle components that were needed for MOTHA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant