Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete redundant pdom options for Dialog's CloseButton. #897

Closed
pixelzoom opened this issue Oct 14, 2024 · 2 comments
Closed

Delete redundant pdom options for Dialog's CloseButton. #897

pixelzoom opened this issue Oct 14, 2024 · 2 comments

Comments

@pixelzoom
Copy link
Contributor

For phetsims/models-of-the-hydrogen-atom#67 ...

In Dialog.ts:

    const closeButton = new CloseButton( {
...
      // pdom
      tagName: 'button',
      innerContent: SunStrings.a11y.closeStringProperty,

The pdom options are redundant and confusing. tagName is set in superclass ButtonNode. innerContent is set as accessibleName in CloseButton.

@pixelzoom pixelzoom self-assigned this Oct 14, 2024
pixelzoom added a commit that referenced this issue Oct 16, 2024
@pixelzoom
Copy link
Contributor Author

@jessegreenberg and I discussed this in Slack, so assigning to him to review. Close if OK.

@jessegreenberg
Copy link
Contributor

Great, thanks!

My understanding is we can delete this a11y string from sun now too, so I removed it in 340c658. If @jbphet says otherwise I will revert that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants