We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For phetsims/models-of-the-hydrogen-atom#67 ...
In Dialog.ts:
const closeButton = new CloseButton( { ... // pdom tagName: 'button', innerContent: SunStrings.a11y.closeStringProperty,
The pdom options are redundant and confusing. tagName is set in superclass ButtonNode. innerContent is set as accessibleName in CloseButton.
tagName
innerContent
accessibleName
The text was updated successfully, but these errors were encountered:
delete redundant pdom options, #897
15f80b8
@jessegreenberg and I discussed this in Slack, so assigning to him to review. Close if OK.
Sorry, something went wrong.
remove SunStrings.a11y.closeStringProperty, see #897
340c658
Great, thanks!
My understanding is we can delete this a11y string from sun now too, so I removed it in 340c658. If @jbphet says otherwise I will revert that.
jessegreenberg
No branches or pull requests
For phetsims/models-of-the-hydrogen-atom#67 ...
In Dialog.ts:
The pdom options are redundant and confusing.
tagName
is set in superclass ButtonNode.innerContent
is set asaccessibleName
in CloseButton.The text was updated successfully, but these errors were encountered: