Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with ?stringTest=dynamic #37

Closed
Tracked by #980
Nancy-Salpepi opened this issue Aug 30, 2023 · 8 comments
Closed
Tracked by #980

Issues with ?stringTest=dynamic #37

Nancy-Salpepi opened this issue Aug 30, 2023 · 8 comments
Assignees
Labels

Comments

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Aug 30, 2023

Test device
MacBook Air M1 chip

Operating System
13.5

Browser
Safari 16.6

Problem description
For phetsims/qa#974, with ?stringTest=dynamic I am seeing two issues:

  1. The units on the ruler:
Screenshot 2023-08-30 at 3 57 10 PM
  1. The scales for Wall Position and Wall Angle can become misaligned:
Screenshot 2023-08-30 at 4 01 04 PM Screenshot 2023-08-30 at 4 01 14 PM
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Sound Waves‬ URL: https://phet-dev.colorado.edu/html/sound-waves/1.0.0-rc.2/phet/sound-waves_all_phet.html?stringTest=dynamic Version: 1.0.0-rc.2 2023-08-28 14:05:18 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36 Language: en-US Window: 1269x729 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@KatieWoe
Copy link

I also saw some oddities if strings were long next to checkboxes.
checkboxsmall

@matthew-blackman
Copy link
Contributor

The issue with ruler is documented in phetsims/scenery-phet#817. Although it is outside the scope of the Sound Waves publication, we should address the dynamic layout issues with RulerNode long-term.

Will address the panel layout issues and leave the ruler alone for this RC.

@matthew-blackman
Copy link
Contributor

This is ready for QA spot-check on main. All dynamic layout issues described above should be fixed except for the ruler for the reasons above.

@KatieWoe
Copy link

KatieWoe commented Sep 6, 2023

I'm still seeing the oddly sized text with long strings on the last screen. With dynamic strings and without.
stillsmall

@matthew-blackman
Copy link
Contributor

The sound mode radio button text was also scaling incorrectly with long strings. Fixed in above commit. We also shortened the "Air Density in Speaker Box" string which was causing the text in the panels on the last screen to shrink more than on other screens.

@marlitas and I are still a bit confused as to how the text across panels is maintaining a single font size, but I think it looks okay and we are happy with the current way that text is dynamically laying out. Ready for spot-check!

@KatieWoe
Copy link

KatieWoe commented Sep 6, 2023

Looks much better on main now

@KatieWoe KatieWoe assigned matthew-blackman and unassigned KatieWoe Sep 6, 2023
@Nancy-Salpepi
Copy link
Author

Everything looks good to me too!

@Nancy-Salpepi
Copy link
Author

Looks good to me in rc.2. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants