-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with ?stringTest=dynamic #37
Comments
The issue with ruler is documented in phetsims/scenery-phet#817. Although it is outside the scope of the Sound Waves publication, we should address the dynamic layout issues with RulerNode long-term. Will address the panel layout issues and leave the ruler alone for this RC. |
This is ready for QA spot-check on main. All dynamic layout issues described above should be fixed except for the ruler for the reasons above. |
The sound mode radio button text was also scaling incorrectly with long strings. Fixed in above commit. We also shortened the "Air Density in Speaker Box" string which was causing the text in the panels on the last screen to shrink more than on other screens. @marlitas and I are still a bit confused as to how the text across panels is maintaining a single font size, but I think it looks okay and we are happy with the current way that text is dynamically laying out. Ready for spot-check! |
Looks much better on main now |
Everything looks good to me too! |
(cherry picked from commit b101b1c)
(cherry picked from commit 863442a)
Looks good to me in rc.2. Closing |
Test device
MacBook Air M1 chip
Operating System
13.5
Browser
Safari 16.6
Problem description
For phetsims/qa#974, with ?stringTest=dynamic I am seeing two issues:
The text was updated successfully, but these errors were encountered: