Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch: three-r131 #90

Open
jonathanolson opened this issue Aug 11, 2021 · 3 comments
Open

branch: three-r131 #90

jonathanolson opened this issue Aug 11, 2021 · 3 comments

Comments

@jonathanolson
Copy link
Contributor

See phetsims/density-buoyancy-common#33
@samreid
Copy link
Member

samreid commented Jul 1, 2022

Since phetsims/density-buoyancy-common#33 (comment) was marked as no-fix, can this branch be deleted? Maybe new sims can use new versions of three from the ground up.

@jonathanolson
Copy link
Contributor Author

I don't see a major drawback of leaving this (since it would be useful code if we're updating three.js for density/buoyancy). Thoughts?

@samreid
Copy link
Member

samreid commented Aug 2, 2022

That sounds reasonable to me, thanks!

@samreid samreid removed their assignment Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @samreid