Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a text (keyboard) input #670

Open
samreid opened this issue Sep 16, 2017 · 12 comments
Open

Add a text (keyboard) input #670

samreid opened this issue Sep 16, 2017 · 12 comments
Assignees

Comments

@samreid
Copy link
Member

samreid commented Sep 16, 2017

In https://github.com/phetsims/circuit-construction-ios-app/issues/5 @mattpen recommended using HTML to render the Circuit Construction iOS App UI, and it seems scenery would give us the most flexibility and control. We will need a text entry field so that users can enter a name for the circuit they save. I'm tagging dev:a11y and @jessegreenberg in case we need to leverage scenery accessibility features to implement this.

@jessegreenberg
Copy link
Contributor

Sounds good, let me know if I can help. Would be very interested to work on this since it could be useful for sims in general.

@jonathanolson
Copy link
Contributor

There are a lot of options potentially available to discuss. Would using an HTML text input with a DOM node be sufficient?

@samreid
Copy link
Member Author

samreid commented Sep 18, 2017

I'll try new DOM() and report back.

@samreid samreid mentioned this issue Sep 18, 2017
@jonathanolson
Copy link
Contributor

Also note that if we're using this more generally, I'll need to review current browser capabilities. Before, there were some browsers (IE?) where Canvas on top would block the ability to input text.

@samreid
Copy link
Member Author

samreid commented Sep 19, 2017

Is there an issue or test harness (and list of potentially problematic platforms)?

@samreid
Copy link
Member Author

samreid commented Sep 19, 2017

I committed sample use of new DOM and it is working for HTML (after focusing properly). For iOS, however, no keyboard is shown (note the Done bar at the bottom though):

image

Instead it gets these errors:

2017-09-18 20:41:39.977591-0600 cck[34326:165174] 0x61000034fe60 Copy matching assets reply: XPC_TYPE_DICTIONARY  <dictionary: 0x61000034fe60> { count = 1, transaction: 0, voucher = 0x0, contents =
	"Result" => <int64: 0x610000239800>: 29
}
2017-09-18 20:41:39.978783-0600 cck[34326:165174] 0x618000147850 Daemon configuration query reply: XPC_TYPE_DICTIONARY  <dictionary: 0x618000147850> { count = 2, transaction: 0, voucher = 0x0, contents =
	"Dictionary" => <dictionary: 0x618000146ca0> { count = 1, transaction: 0, voucher = 0x0, contents =
		"ServerURL" => <dictionary: 0x6180001474e0> { count = 3, transaction: 0, voucher = 0x0, contents =
			"com.apple.CFURL.magic" => <uuid: 0x6180000550c0> C3853DCC-9776-4114-B6C1-FD9F51944A6D
			"com.apple.CFURL.string" => <string: 0x6180000551e0> { length = 30, contents = "https://mesu.apple.com/assets/" }
			"com.apple.CFURL.base" => <null: 0x10ed29f40>: null-object
		}
	}
	"Result" => <int64: 0x61800003c9e0>: 0
}
2017-09-18 20:41:39.979502-0600 cck[34326:165174] [MobileAssetError:29] Unable to copy asset information from https://mesu.apple.com/assets/ for asset type com.apple.MobileAsset.TextInput.SpellChecker

Perhaps it couldn't find an autocomplete/spellchecker, so failed out the keyboard?

@samreid
Copy link
Member Author

samreid commented Sep 19, 2017

According to turbolinks/turbolinks-ios#73 (comment) the log is just noisy and this is what happens when the simulator is taking data from a real keyboard. I tried typing on the real keyboard and it worked nicely.

@jonathanolson
Copy link
Contributor

Is there an issue or test harness (and list of potentially problematic platforms)?

Created /scenery/tests/stacking-test.html for testing the "DOM under canvas" problem. I don't immediately see an issue referenced.

@samreid
Copy link
Member Author

samreid commented Sep 19, 2017

Removing my assignment until we have a design in https://github.com/phetsims/circuit-construction-ios-app/issues/5

@samreid samreid removed their assignment Sep 19, 2017
@jessegreenberg
Copy link
Contributor

Removing my assignment, but please let me know if I can be of help for this.

@jessegreenberg jessegreenberg removed their assignment Sep 26, 2017
@pixelzoom pixelzoom changed the title Add a text input Add a text (keyboard) input Jun 10, 2022
@zepumph
Copy link
Member

zepumph commented Feb 23, 2024

This doesn't feel like it is part of the alt-input work going on right now.

@zepumph
Copy link
Member

zepumph commented Mar 6, 2024

This issue was upvoted over in phetsims/scenery-phet#678, where it would have been really nice to support this for the editable number display in Fourier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants