Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button icon licensing issues #883

Open
jonathanolson opened this issue Oct 30, 2024 · 5 comments
Open

Button icon licensing issues #883

jonathanolson opened this issue Oct 30, 2024 · 5 comments

Comments

@jonathanolson
Copy link
Contributor

jonathanolson commented Oct 30, 2024

We're advertising scenery-phet as MIT licensed, which means we can't use font-awesome 5 icons (which are CC-By licensed, explicitly noted at https://github.com/phetsims/sherpa/blob/main/licenses/fontawesome-free-5.15.2-desktop.txt#L8).

It looks like we have licensing issues with:

  • CameraButton
  • CanvasWarningNode
  • ClapperboardButton
  • ContextLossFailureDialog
  • EyeToggleButton
  • InfoButton
  • MoveToTrashButton
  • RefreshButton
  • SoundToggleButton
  • TrashButton

It looks like a lot of these conversions happened as part of phetsims/sherpa#83. I'm including @samreid.

So we can either:

  1. Remove font-awesome 5 content from scenery-phet (maybe a repo for sim-licensed things?)
  2. Change scenery-phet's license (but there's a LOT of content we want MIT licensed in here. If we change the license, we'd need to move a bunch of content and potentially phet-specific stuff to sun (or some new repository in the "middle", e.g. "MIT licensed but not general UI components like Sun"
  3. Undo the conversion to FA-5 that we did earlier.

Thoughts?

@jonathanolson
Copy link
Contributor Author

Also including @brettfiedler, since if we have things using font-awesome 5 icons, they can't be included in scenery-stack.

@jonathanolson
Copy link
Contributor Author

This is also blocking any THREE.js integration (mobius now uses a FA-5 icon with phetsims/mobius@ffad97db).

@jonathanolson
Copy link
Contributor Author

Unblocked by adding FA-4 warning sign back.

@samreid
Copy link
Member

samreid commented Oct 30, 2024

It seems preferable to avoid licensing encumbrances for scenery-stack, so I agree we should avoid FA-5 there.

Font Awesome 4 is licensed as SIL OFL 1.1 https://fontawesome.com/v4/license/, which does not require attribution (though outside of the license text, the author said attribution is not required but much appreciated.

Where the icons look similar, it seems safe to go back to FA-4. We kept a few FA-4 things around in sherpa anyways (checkEmptySolidShape, checkSquareOSolidShape, scissorsShape).

We can also consider open source MIT licensed icons libraries such as https://heroicons.com/ which look nice.

@pixelzoom
Copy link
Contributor

pixelzoom commented Oct 30, 2024

Unassigning myself. PixelZoom does not provide legal advice or consulting on licensing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants