You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Identified by @arouinfar during review of MSS PhET-iO. And according to @matthew-blackman, this will also be an issue for PM"DL.
TimeControlNode has 2 significant problems for PhET-iO:
(1) It needs a PhET-iO design. It's over-instrumented, and doesn't support opting out/in of instrumented some subcomponents. See for example phetsims/my-solar-system#301.
(2) It has dynamic layout problems. See problem description and recommended solution in phetsims/my-solar-system#300.
It looks like others may have encountered this previously. In 1927a55 for #575, @jessegreenberg added options wrapSpeedRadioButtonGroupInPanel and speedRadioButtonGroupPanelOptions, presumably because wrapping the radio button group in a panel makes the dynamic layout behave properly. Those options were used only in neuron, but now we also needed to use them in solar-system-common (my-solar-system, keplers-laws).
PhET-iO makes this a problem for all sims. So I recommend that those options be deleted, and the dynamic layout be generalized so that is always works properly.
Regarding the positioning of the speed radio button group, I recommend replacing option speedRadioButtonGroupOnLeft: boolean with speedRadioButtonGroupPosition: 'left' | 'right' | 'bottom' ('top' is probably not necessary), then handling the layout accordingly.
The ugly/unsafe workaround for 'bottom' placement in SolarSystemCommonTimeControlNode should then be deleted.
Identified by @arouinfar during review of MSS PhET-iO. And according to @matthew-blackman, this will also be an issue for PM"DL.
TimeControlNode has 2 significant problems for PhET-iO:
(1) It needs a PhET-iO design. It's over-instrumented, and doesn't support opting out/in of instrumented some subcomponents. See for example phetsims/my-solar-system#301.
(2) It has dynamic layout problems. See problem description and recommended solution in phetsims/my-solar-system#300.
It's unclear whether this is blocking for MSS PhET-iO 1.3 (phetsims/my-solar-system#282).
The text was updated successfully, but these errors were encountered: