Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NumberControl's layoutFunctions should be resizable #778

Open
jonathanolson opened this issue Oct 20, 2022 · 5 comments
Open

NumberControl's layoutFunctions should be resizable #778

jonathanolson opened this issue Oct 20, 2022 · 5 comments
Assignees
@jonathanolson
Labels
priority:2-high

Comments

@jonathanolson
Copy link
Contributor

Currently layout 4 is resizable (I needed that for a sim) but the others are not. They should support dynamic content.
@jonathanolson jonathanolson self-assigned this Oct 20, 2022
@jonathanolson
Copy link
Contributor Author

Came upon this in MSS, we'd really want it to respect a preferred size, so it can expand to match.

jonathanolson added a commit that referenced this issue May 18, 2023
@jonathanolson
NumberControl dynamic layout, see #778
8bebb63
@jonathanolson
Copy link
Contributor Author

Implemented above. @marlitas can you review?

@zepumph zepumph mentioned this issue May 22, 2023
Closed
@zepumph
Copy link
Member

zepumph commented May 22, 2023

@samreid and I can confirm that there is an infinite from these commits causing #809. When we checkout 8bebb63 then we cannot reproduce the infinite loop in the scenery-phet demo. I would recommend putting this back to @jonathanolson with a high priority before review.

@marlitas
Copy link
Contributor

marlitas commented Feb 9, 2024

Sorry for the delay getting here... I'm going to go ahead and unassign myself since it looks like it needs to be sent back to @jonathanolson before it's ready.

@marlitas marlitas removed their assignment Feb 9, 2024
@jonathanolson
Copy link
Contributor Author

Looks like the infinite loop isn't happening. Perhaps I can review it with @jessegreenberg this iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
priority:2-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathanolson @zepumph @marlitas