Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rosetta features #358

Open
liammulh opened this issue Jan 18, 2023 · 1 comment
Open

New Rosetta features #358

liammulh opened this issue Jan 18, 2023 · 1 comment

Comments

@liammulh
Copy link
Member

liammulh commented Jan 18, 2023

This is an issue for collecting other issues/features we might want in future versions of Rosetta.

Difficulty

  • easy = 1
  • medium = 2
  • hard = 3

Value

  • unimportant = 1
  • nice-to-have = 2
  • important = 3

Issue Actionable for LM? Value Difficulty Done? Notes
Integrate website styling? No 2 2 Requires coordination with MP. Website uses Less. Rosetta would have to use classes that the website uses.
Integrate website header? No 2 3 Requires work from MP. Right now, the header is written in TomCat. Things are ported to React on an as-needed basis. Let's do this after we migrate the website header to React. (This is probably a year away because there's a lot of pages that depend on the header we'd also need to port.)
#301 No 3 2 Requires MP to add translator's locale(s) to check-login object.
#354 Yes 2 2 n/a
#336 Yes 2 1 n/a
#333 No 2 2 This is two issues: (1) Should we match the English string? (2) Should we ensure the opening tags have corresponding closing tags? It would be nice to get translator feedback on (1).
#337 Yes 2 2 n/a
#349 No 2 1 We should discuss this in a design meeting so that Rosetta isn't adding band-aid solutions to problems that were introduced in upstream design decisions.
#353 No ? ? n/a
#356 Yes 2 1 Related to #349.
#327 No 2 3 Requires design from LM and JB.
#325 No 2 ? Wait until usePrompt and useBlocker are stable in React Router V6. (They are added, but unstable as of January 21st, 2023.)
#323 Yes 2 1 Have JB review this.
#316 No 1 ? Need to figure out how to get repo's SHA in order to bust GitHub's cache.
#314 No 3 ? Requires design time.
#311 No 3 2 LM needs to know what TS rules we want to include for Rosetta.
#304 No 2 2 Need to figure out how to tell when a file was pushed to GitHub.
#302 No 3 ? Don't even have a rough idea of how to do this.
@liammulh liammulh changed the title Rosetta 2.1 New Rosetta features Jan 20, 2023
@liammulh
Copy link
Member Author

@kathy-phet, @oliver-phet, @jbphet, I've organized the new features we might want into the above table. There are columns for whether the feature is actionable, value, difficulty, and notes.

Once we have a better idea of the timeline for Rosetta 2.1, we use the above table to decide which features to include.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant