Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Photon outline is a bit pixelated #77

Closed
AgustinVallejo opened this issue Jan 6, 2025 · 2 comments
Closed

Photon outline is a bit pixelated #77

AgustinVallejo opened this issue Jan 6, 2025 · 2 comments
Assignees
@AgustinVallejo

Comments

@AgustinVallejo
Copy link
Contributor

AgustinVallejo commented Jan 6, 2025 •
edited
Loading

Image
@jbphet
Copy link
Collaborator

jbphet commented Jan 22, 2025

I recently made some changes to the photon outline for #81, and it now appears less pixelated on my Win 11 machine using Chrome. Here is an unzoomed screen shot:

Image

@AgustinVallejo - Can you check things out on your end and see if you think this has been sufficiently addressed?

@jbphet jbphet assigned AgustinVallejo and unassigned jbphet Jan 22, 2025
AgustinVallejo added a commit that referenced this issue Jan 28, 2025
@AgustinVallejo
Making photon outline its own image to prevent over-rasterization, see …
dfd06b8 
…#77
@AgustinVallejo
Copy link
Contributor Author

AgustinVallejo commented Jan 28, 2025 •
edited
Loading

Image

I was still seeing it when zoomed, so I took the liberty of using a custom outline image with similar dimensions to the photon interior one, and now it looks really crisp. Happy to close this after discussing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AgustinVallejo AgustinVallejo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbphet @AgustinVallejo