Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UI sound, review the result #72

Open
jbphet opened this issue Dec 20, 2024 · 1 comment
Open

Enable UI sound, review the result #72

jbphet opened this issue Dec 20, 2024 · 1 comment
Assignees

Comments

@jbphet
Copy link
Collaborator

jbphet commented Dec 20, 2024

The design document for this sim says, "Start with supportsSound=true and evaluate. If sim sounds empty or provides insufficient feedback, will either progress to full sound design or turn off sounds entirely." @AgustinVallejo and I will now turn on sound and start this process.

@jbphet
Copy link
Collaborator Author

jbphet commented Dec 20, 2024

Sound has now been turned out and can be tried out on phettest. I took it for a test drive and IMO it's okay, but not great. Probably better than nothing. I have a few thoughts about how to improve things without a full sound design:

  • It would be nice to use a non-default sound for the green arrow button and the "New Coin" button on the 1st screen. Having all the buttons, including those on the tweakers, use the same sound seems repetitive. We could probably just use some existing sound for this.
  • The momentary buttons for firing the photons and the individual particles on screens 2 & 3 makes two sounds, one when pressed and one when released. It's a bit much. It would be nice to turn off the release sound.
  • The sliders on the first and second screen would benefit from having a few more ticks. The default number seems a bit low.
  • It would be nice to have a "photon detected" sound for the "Single Photon" mode in screen 2.
  • It might be good to have a low, non-intrusive sound for photons reaching the detector in the "Many Photons" mode of screen 2.

Assigning to @arouinfar for review and discussion of next steps, including whether to do the items listed above.

@jbphet jbphet assigned arouinfar and unassigned jbphet and AgustinVallejo Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants