Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should it be possible to display the expectation value in the Single Photon mode? #60

Open
jbphet opened this issue Nov 14, 2024 · 1 comment
Assignees

Comments

@jbphet
Copy link
Collaborator

jbphet commented Nov 14, 2024

As of this writing, the design document doesn't show the "Expectation Value" checkbox in the "Single Photon" mode - it's only shown for the "Many Photons" mode. I asked in yesterday's design meeting if we might want to allow the user to see the expectation value in the single-photon mode, since it's kind of cool to see the graph converge to it as the number of samples increases. We discussed pros and cons of this, and ultimately decided to show it in both modes and run the question by our consulting teachers when we get a chance. I've made this change and will mark the related code with a TODO that references this issue.

@jbphet
Copy link
Collaborator Author

jbphet commented Nov 14, 2024

It's set up to show in both modes and the TODO is in the code. Assigning to @arouinfar for follow-up with our consulting instructors.

@jbphet jbphet assigned arouinfar and unassigned jbphet Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants