Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only 1 or 9 clicks available #29

Open
Tracked by #855
KatieWoe opened this issue Nov 4, 2022 · 4 comments
Open
Tracked by #855

Only 1 or 9 clicks available #29

KatieWoe opened this issue Nov 4, 2022 · 4 comments
Labels

Comments

@KatieWoe
Copy link

KatieWoe commented Nov 4, 2022

Device
Galaxy Tab S7
OS
Android 12
Browser
Chrome
Problem Description
For phetsims/qa#849
On the Clicks screen, if you try to change the number of Multi clicks, you can only get 1 or 9. You get 1 if you use the back arrow, and any other input is interpreted as 9.
Visuals

IMG_4480.MOV
@KatieWoe KatieWoe added the type:bug Something isn't working label Nov 4, 2022
@stemilymill
Copy link

As I mentioned to Katie earlier, here is an earlier documented example of this problem and the non-ideal workaround.

#23 (comment)

I also took a video of the process to actually change the number of clicks to anything besides 1 or 9.

Screen_Recording_20221107_121739_HapticsPlayground.mp4

@jbphet
Copy link
Contributor

jbphet commented Nov 8, 2022

This should now be fixed. I changed the intended behavior a bit too - it now limits the valid range to 3-10, inclusive. This is because values of 1 and 2 don't really make sense given that there are buttons for single and double clicks, and a max of 10 just felt like a reasonable amount.

@jbphet
Copy link
Contributor

jbphet commented Nov 8, 2022

Unassigning for now, will have QA verify in next release.

@KatieWoe
Copy link
Author

This looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants