Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance and Launch Angle values overlap with ?stringTest=dynamic #286

Closed
Tracked by #1079
Nancy-Salpepi opened this issue Apr 10, 2024 · 7 comments
Closed
Tracked by #1079

Comments

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Apr 10, 2024

Test device
MacBook Air M1 chip

Operating System
14.4.1

Browser
Safari 17.4.1

Problem description
For phetsims/qa#1068, on the first 3 screens when the measuring tape is in the default position, the distance value may occlude Launch Angle value. This is seen with ?stringTest=dynamic.

Steps to reproduce

  1. Add ?stringTest=dynamic to url
  2. Go to any of the first 3 screens, and check Measuring Tape and Launch Angle checkboxes
  3. Press the right arrow key a couple of times

Visuals

labelsOverlap.mp4
@Nancy-Salpepi
Copy link
Author

also overlap when the launch angle is zero (although I'm not sure what can be done about any of these instances):
Screenshot 2024-04-10 at 3 56 13 PM

@samreid
Copy link
Member

samreid commented Apr 12, 2024

In discussion with @matthew-blackman, perhaps the readout could be above the measuring tape? That won't overlap other things and won't be occluded by a finger on mobile.

  • move measuring tape text above

@matthew-blackman also recommends:

  • reducing the maxWidth of the heat map value readouts
  • adjusting the position of the raised launcher angle readout

@samreid
Copy link
Member

samreid commented Apr 15, 2024

I addressed the recommendations above.

@matthew-blackman can you please review/test?

image image image

@matthew-blackman
Copy link
Contributor

The updated layout and positioning looks good. Nice work @samreid! The distance text works well above the tape measure. I reviewed the commits and all are very straightforward. Marking as ready to cherry-pick.

@matthew-blackman matthew-blackman removed their assignment Apr 17, 2024
matthew-blackman pushed a commit that referenced this issue Apr 22, 2024
matthew-blackman pushed a commit that referenced this issue Apr 22, 2024
matthew-blackman pushed a commit that referenced this issue Apr 22, 2024
matthew-blackman pushed a commit that referenced this issue Apr 22, 2024
@matthew-blackman
Copy link
Contributor

Please close after verifying.

@KatieWoe
Copy link

Only minor note is that the tape itself can cover important speed info when launching from a zero angle. If this is alright, it can be closed.
minornote

@samreid samreid removed their assignment Apr 29, 2024
@samreid
Copy link
Member

samreid commented Apr 30, 2024

@matthew-blackman and I discussed it and agreed it is OK. Closing.

@samreid samreid closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants