-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distance and Launch Angle values overlap with ?stringTest=dynamic #286
Comments
In discussion with @matthew-blackman, perhaps the readout could be above the measuring tape? That won't overlap other things and won't be occluded by a finger on mobile.
@matthew-blackman also recommends:
|
I addressed the recommendations above. @matthew-blackman can you please review/test? |
The updated layout and positioning looks good. Nice work @samreid! The distance text works well above the tape measure. I reviewed the commits and all are very straightforward. Marking as ready to cherry-pick. |
(cherry picked from commit 795a611)
(cherry picked from commit 7b16736)
(cherry picked from commit fe6c0e8)
(cherry picked from commit ef9cfb6)
Please close after verifying. |
@matthew-blackman and I discussed it and agreed it is OK. Closing. |
Test device
MacBook Air M1 chip
Operating System
14.4.1
Browser
Safari 17.4.1
Problem description
For phetsims/qa#1068, on the first 3 screens when the measuring tape is in the default position, the distance value may occlude Launch Angle value. This is seen with ?stringTest=dynamic.
Steps to reproduce
Visuals
labelsOverlap.mp4
The text was updated successfully, but these errors were encountered: