Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should I hear radiobutton sound when selecting field using hotkeys? #284

Closed
Tracked by #1079
Nancy-Salpepi opened this issue Apr 10, 2024 · 6 comments
Closed
Tracked by #1079

Should I hear radiobutton sound when selecting field using hotkeys? #284

Nancy-Salpepi opened this issue Apr 10, 2024 · 6 comments
Labels
design:sound status:ready-for-review status:ready-to-cherry-pick type:question Further information is requested

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
14.4.1

Browser
Safari 17.4.1

Problem description
For phetsims/qa#1068, on the first 3 screens I don't hear any sound when I switch fields using the hot keys. Should I hear the radio button sound here? It seems oddly quiet.
@Nancy-Salpepi Nancy-Salpepi added type:question Further information is requested design:sound labels Apr 10, 2024
matthew-blackman added a commit that referenced this issue Apr 10, 2024
@matthew-blackman
Add radio button sound to field hotkey press - see #284
ed44170
@matthew-blackman
Copy link
Contributor

Good idea! This has been added in the commit. Feel free to close if it sounds okay to you.

@Nancy-Salpepi
Copy link
Author

Sounds great! Since this is an RC, keeping open for verification in next RC.

@Nancy-Salpepi
Copy link
Author

@matthew-blackman what are your thoughts on hearing a sound when I jump to the first/last projectile on the Field Sign using home and end keys?

@matthew-blackman
Copy link
Contributor

@Nancy-Salpepi also oddly quiet. Can you open an issue?

@matthew-blackman matthew-blackman removed their assignment Apr 16, 2024
matthew-blackman added a commit that referenced this issue Apr 22, 2024
@matthew-blackman
Add radio button sound to field hotkey press - see #284
3aaeac8 
(cherry picked from commit ed44170)
@matthew-blackman
Copy link
Contributor

Please close after verifying.

@matthew-blackman matthew-blackman mentioned this issue Apr 26, 2024
Closed
28 tasks
@KatieWoe
Copy link

Looks good in rc.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design:sound status:ready-for-review status:ready-to-cherry-pick type:question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KatieWoe @Nancy-Salpepi @matthew-blackman