You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For description-related strings, it's not clear if this convention is still appropriate.
In MOTHA, where description strings live under ModelsOfTheHydrogenAtom.a11y, I feel that the UI convention is NOT appropriate for strings related to accessibleName and helpText -- there is not enough information about the string's context. So I experimented with adding a "HelpText" suffix, like this:
"a11y": {
"absorptionAndEmission": {
"value": "Absorption and Emission"
},
"absorptionAndEmissionHelpText": {
"value": "Show Absorption and Emission dialog for electron state transitions and their associated wavelengths."
},
...
This still does not feel sufficient for the ModelsOfTheHydrogenAtom.a11y approach. And it's hard to know what will be sufficient until decisions are made about how translation will be supported for description.
In any case... Conventions for naming string keys should definitely be a discussed.
The text was updated successfully, but these errors were encountered:
@jessegreenberg and I discussed this one. Before description strings are publicly released for translation, it's important to have conventions for string keys -- they are almost impossible to change later. Until we know when and how description translation is going to be done, we don't know if this issue is blocking for the MOTHA 1.0 release. My crystal ball says that we will be ready to release MOTHA 1.0 before PhET has a description translation solution, and that we should therefore leave the description strings "as is", under the "a11y" grouping where they are not visible in Rosetta, and can be changed in the future.
Related to phetsims/models-of-the-hydrogen-atom#67 and https://github.com/phetsims/scenery-phet/issues/876 ...
For strings that appear in the UI, PhET's convention is to use the English string as the string key. Some typical examples, from MOTHA:
For description-related strings, it's not clear if this convention is still appropriate.
In MOTHA, where description strings live under
ModelsOfTheHydrogenAtom.a11y
, I feel that the UI convention is NOT appropriate for strings related to accessibleName and helpText -- there is not enough information about the string's context. So I experimented with adding a "HelpText" suffix, like this:This still does not feel sufficient for the
ModelsOfTheHydrogenAtom.a11y
approach. And it's hard to know what will be sufficient until decisions are made about how translation will be supported for description.In any case... Conventions for naming string keys should definitely be a discussed.
The text was updated successfully, but these errors were encountered: