Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusing UI strings for description. #227

Open
pixelzoom opened this issue Oct 20, 2024 · 0 comments
Open

Reusing UI strings for description. #227

pixelzoom opened this issue Oct 20, 2024 · 0 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Oct 20, 2024

Related to phetsims/models-of-the-hydrogen-atom#67 and https://github.com/phetsims/scenery-phet/issues/876 ...

An important decision for i18n is when/whether to reuse UI strings for description.

Different developers/designers have been taking different approaches:

  • In MSaB, the goals was to have 100% of description strings under MeanShareAndBalanceStrings.a11y, therefore duplicating strings that appear in the UI.
  • In Density/Buoyancy, the developers reused UI strings were possible. Strings were added under a11y only when they were unique to description.
  • The MOTHA team consensus was to use the same approach as Density/Buoyancy. But that was only after I has already implemented using the MSaB approach. And I have not changed anything because there is not PhET-wide consensus.

My feeling is that is appropriate to reuse UI strings for description when the contexts are the same. For example, if the an accessibleName is intended to match the label on a button, then use the same string Property for both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants