Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daily grunt work investigation #408

Open
zepumph opened this issue Nov 12, 2024 · 2 comments
Open

Daily grunt work investigation #408

zepumph opened this issue Nov 12, 2024 · 2 comments
Assignees
@zepumph
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Nov 12, 2024

@jessegreenberg reported that a few days after changes I made, grunt update still showed working copy changes. Daily grunt work should handle this.
zepumph added a commit that referenced this issue Nov 12, 2024
@zepumph
log task names to stderr too, #408
da349eb
@zepumph zepumph changed the title Grunt update investigation Daily grunt work investigation Nov 12, 2024
@zepumph zepumph self-assigned this Nov 12, 2024
zepumph added a commit that referenced this issue Nov 12, 2024
@zepumph
date in std err too, #408
ba5ff26
zepumph added a commit that referenced this issue Nov 12, 2024
@zepumph
add a log, #408
03caca4
zepumph added a commit that referenced this issue Nov 12, 2024
@zepumph
stash before anything else, #408
1614516
zepumph added a commit that referenced this issue Nov 12, 2024
@zepumph
add grunt update, #408
c8c9ab4
@zepumph
Copy link
Member Author

zepumph commented Nov 12, 2024

Oh my. I was surprised to see that daily-grunt-work actually doesn't run grunt update. That means that the whole codebase is likely a bit off from what tasks like modulify expect. Committed now. I'll see how it goes tonight.

samreid added a commit to phetsims/forces-and-motion-basics that referenced this issue Nov 12, 2024
@samreid
grunt update, see #314 and phetsims/perennial#408
7824a0c
zepumph added a commit that referenced this issue Nov 13, 2024
@zepumph
add npm and node versions, #408
abac4a9
zepumph added a commit that referenced this issue Nov 13, 2024
@zepumph
update task name, #408
f8b462d
@zepumph
Copy link
Member Author

zepumph commented Nov 13, 2024

I believe everything is looking great. I noticed that the cronjobs are still using node 16, so I updated that, and few more minor tweaks. I'll check in after tonight again.

  • Turn off page logging for binder doc generation.

zepumph added a commit that referenced this issue Nov 15, 2024
@zepumph
commit and push after all updates, #408
be19327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepumph zepumph

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zepumph