You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the last month or two, many more copies of spawn() have been hard coded into our processes. This is because execute is unwieldy and heavy weight, and it too scary to change. At this time we have 8 copies of spawn in chipper and perennial. Let's also look at exec and execSync is we are so inclined.
The text was updated successfully, but these errors were encountered:
In my opinion, execute is problematic and should be avoided:
// {'reject'|'resolve'} - whether errors should be rejected or resolved. If errors are resolved, then an object
// - of the form {code:number,stdout:string,stderr:string} is returned. 'resolve' allows usage
// - in Promise.all without exiting on the 1st failure
It sounds like we were unaware of Promise.allSettled.
Why have an option that radically changes the behavior? Is ExecuteError valuable?
In my opinion, it is clearer and more idiomatic to use spawn directly. We should learn to use it and become comfortable with it. The main/only thing we should factor out to spawn usages is shell: /^win/.test( process.platform )
In the last month or two, many more copies of spawn() have been hard coded into our processes. This is because
execute
is unwieldy and heavy weight, and it too scary to change. At this time we have 8 copies ofspawn
in chipper and perennial. Let's also look atexec
andexecSync
is we are so inclined.The text was updated successfully, but these errors were encountered: