Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How/Should perennial be able to use code from phet-core, like IntentionalAny? #371

Open
samreid opened this issue Oct 11, 2024 · 2 comments
Open

How/Should perennial be able to use code from phet-core, like IntentionalAny? #371

samreid opened this issue Oct 11, 2024 · 2 comments
Labels
status:on-hold

Comments

@samreid
Copy link
Member

samreid commented Oct 11, 2024

How/Should perennial be able to use code from phet-core, like IntentionalAny? Keep in mind we do not want to create phet-core-alias.
@samreid samreid mentioned this issue Oct 11, 2024
Closed
10 tasks
samreid added a commit that referenced this issue Oct 11, 2024
@samreid
Move TODOs, see phetsims/chipper#1469 and #371
e553002
samreid added a commit to phetsims/aqua that referenced this issue Oct 11, 2024
@samreid
Move TODOs, see phetsims/chipper#1469 and phetsims/perennial#371
8532c0e
@samreid
Copy link
Member Author

samreid commented Nov 3, 2024

I am reluctant to move more code to perennial while we have this problem: #363

@zepumph zepumph self-assigned this Nov 6, 2024
@samreid samreid assigned samreid and unassigned zepumph Nov 6, 2024
@samreid
Copy link
Member Author

samreid commented Nov 6, 2024

@jonathanolson @zepumph and I met today to discuss #363 and agreed that #401 would be good to investigate.

We do not want to move phet-core code such as optionize or IntentionalAny to perennial. Instead, we would prefer that perennial can depend on phet-core. In order to do so without creating phet-core-alias, we will investigate the above approaches.

Until then, perennial should use any instead of IntentionalAny and assignIn or other alternatives to optionize.

samreid added a commit that referenced this issue Nov 6, 2024
@samreid
Update TODOs, see #371
fb25bd1
samreid added a commit to phetsims/aqua that referenced this issue Nov 6, 2024
@samreid
Update TODOs, see phetsims/perennial#371
274749c
@samreid samreid removed their assignment Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:on-hold
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samreid @zepumph