Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer abbreviated units in model Properties? #161

Open
zepumph opened this issue Mar 27, 2020 · 4 comments
Open

prefer abbreviated units in model Properties? #161

zepumph opened this issue Mar 27, 2020 · 4 comments

Comments

@zepumph
Copy link
Member

zepumph commented Mar 27, 2020

From #159, I know that in units.js it says to prefer abbreviated units. This would mean making the following changes to units passed to Properties in OhmsLawModel.js

  • volts -> V
  • milliamperes -> mA
  • ohms -> Ω

@samreid does this feel like something I should do?

@samreid
Copy link
Member

samreid commented Mar 28, 2020

The rule of thumb we discussed with @pixelzoom is that the Property units should match what is shown in the user interface. So, using V, mA, A and Ω sounds good to me.

@samreid samreid assigned pixelzoom and unassigned samreid Mar 28, 2020
@pixelzoom
Copy link
Contributor

Yep, agreed.

Should spend the time to do this project-wide? That would mean addressing these notes in units.js:

// NOTE: Abbreviations are preferred, see https://github.com/phetsims/phet-io/issues/530

// NOTE: In time, these will be replaced with abbreviations, see above.

@pixelzoom pixelzoom assigned samreid and zepumph and unassigned pixelzoom Mar 28, 2020
@pixelzoom
Copy link
Contributor

And I seem to recall that '\u2126' is preferred to 'Ω'.

@samreid
Copy link
Member

samreid commented Mar 28, 2020

I recall that consensus as well, though not the reasoning behind it.

@samreid samreid removed their assignment Aug 19, 2020
@zepumph zepumph removed their assignment Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants