Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify reusable code for speech-synthesis feature. #22

Open
pixelzoom opened this issue Oct 29, 2024 · 1 comment
Open

Identify reusable code for speech-synthesis feature. #22

pixelzoom opened this issue Oct 29, 2024 · 1 comment
Assignees

Comments

@pixelzoom
Copy link
Collaborator

pixelzoom commented Oct 29, 2024

number-pairs is currently not reusing anything from number-suite-common. And we probably need to keep it that way for now, due to PhET-iO support issues. But there is a lot of existing code related to the speech-synthesis feature that we should inspect, especially since the design is the same for number-pairs. Some code we might consider generalizing, adding PhET-iO support, and moving to common code. Other code we might be able to copy and improve.

Here's the existing code that's related to the speech synthesis feature. (This might not be a complete list.)

number-suite-common:

  • LanguageAndVoiceControl - 2 carousels that replace the standard UI in Preferences > Localization
  • SecondLanguageControl - ABSwitch and 1 carousel that typically appears in Preferences > Simulation
  • SpeechSynthesisButton
  • NoVoiceWarningButton
  • NoVoiceWarningDialog

number-play:

  • LocaleSwitch - ABSwitch between primary and secondary locale
  • numberPlaySpeechSynthesisAnnouncer
  • numberPlayUtteranceQueue

number-compare:

  • numberCompareSpeechSynthesisAnnouncer
  • numberCompareUtteranceQueue
@pixelzoom pixelzoom self-assigned this Oct 29, 2024
@pixelzoom
Copy link
Collaborator Author

LanguageAndVoiceControl and SecondLanguageControl were components that I thought would be good candiates to move to joist. But looking at their current implementations, they are tightly coupled to UtteranceQueue in general, and the NumberSuiteCommonUtteranceQueue subclass of UtteranceQueue in particular. So the first order of business will be to see if they can be decoupled.

@pixelzoom pixelzoom mentioned this issue Nov 5, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant