Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description for "Absorption and Emission" dialog content. #79

Closed
pixelzoom opened this issue Nov 6, 2024 · 5 comments
Closed

Add description for "Absorption and Emission" dialog content. #79

pixelzoom opened this issue Nov 6, 2024 · 5 comments

Comments

@pixelzoom
Copy link
Contributor

In #67 (comment), @terracoda asked:

How difficult is it to put the static content of the dialog in the sim, assuming the content is static? Are the different symbols different types of photons?

Quite difficult. The static content is a large collection of buttons and text, and there’s no framework for coalescing that into “static content”. I suspect that this woud be several hours of design and implementation work, involving multiple people.

@kathy-phet do you want to pursue this?

@pixelzoom pixelzoom changed the title Description for Absorption/Emission dialog content. Add description for Absorption/Emission dialog content. Nov 7, 2024
@kathy-phet
Copy link

Putting all of this information in is beyond the scope for MOTHA, but @jessegreenberg was going to update the Dialog API for sim-devs to have some options:

  • take rich-text and strip it to plain text for the dialog content was one (this table seems too complex for this option though?)

Another option would be to have an option to pass a simplified description of what is shown in the dialog and this option seems like a good tier 1 option to have for complex dialogs. An optional string to pass in ... should not be called accessible name, since its the content not the name. Since this is passing a Node, maybe it is an option that lives on the general Node common component?

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Nov 7, 2024

11/7/24 design meeting: @DianaTavares @arouinfar @kathy-phet @terracoda @LindaStegemann @ariel-phet @KatieWoe @pixelzoom

@pixelzoom will add helpText for the "Absorption and Emission" dialog (which is actually a Panel):

helpText: 'Use the buttons to set the light source to a specific wavelength.'

@jessegreenberg Will make the default for Panel to put helpText before content.

@pixelzoom pixelzoom changed the title Add description for Absorption/Emission dialog content. Add description for "Absorption and Emission" dialog content. Nov 7, 2024
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Nov 7, 2024

Help text was added, shown below in A11y View.

Over to @jessegreenberg to put helpText before content as the default for Panel.

screenshot_3587

@pixelzoom pixelzoom removed their assignment Nov 7, 2024
@jessegreenberg
Copy link
Contributor

This was done in phetsims/sun#912.

@pixelzoom
Copy link
Contributor Author

Tested MOTHA in A11y View, looks great - thanks @jessegreenberg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants