Change description for Light Source.

[pixelzoom]

In #67 (comment), @terracoda said:

The Light Source interaction is not being communicated as an on/off switch like in Molecules and Light. Are they not the same component?

They are not the same component. MOTHA uses scenery-phet's LaserPointerNode, which can be configured to use a RoundStickyToggleButton or RoundMomentaryButton. MAL has its own sim-specific component (no common code) called PhotonEmitterNode. It does some configuration of ARIA-related attributes, but I can't tell why or what parts are relevant for MOTHA -- there are no details in the code comments, and I can find no paper trail for the description design.

Also note that @jessegreenberg and I did considerable work on LaserPointerNode in phetsims/scenery-phet#877. That work was informed by the requirements provided by the description designers in our 10/15/2 MOTHA meeting. If something different is desired, then that issue should be reopened, and a general solution (based on MAL PhotonEmitterNode?) implemented in LaserPointerNode.

[kathy-phet]

Initially, this looks like the common code RoundStickyToggleButton needs @jessegreenberg to work at the lower level scenery piece so the pdom implementation is appropriate for a sticky toggle kind of button.

[pixelzoom]

11/7/24 design meeting: @DianaTavares @arouinfar @kathy-phet @terracoda @LindaStegemann @ariel-phet @KatieWoe @pixelzoom

@jessegreenberg will work on this. Likely down in RoundStickyToggleButton. Should probably be aria-role='switch'.

[jessegreenberg]

This was done in phetsims/sun#913.

[pixelzoom]

@jessegreenberg I'm unclear on how to review this. Can you describe what the expected behavior is now? I don't see anything different in A11y View -- I was expecting to see ARIA state showing whether the toggle is on/off, similar to what you did for the expand/collapse button in Accordion Box. Or is there no change in A11y View, but change only in screen reader behavior?

To clarify... For MOTHA A11y View, here's what I see for the light source toggle button:

Here's what I see for an accordion box:

So I was expecting to see similar ARIA state information for toggle button.

[jessegreenberg]

Correct, no visible changes in the a11y view yet - only screen reader behavior. The only aria attributes we display in the a11y view right now are aria-valuetext and aria-expanded. We will flesh that out in phetsims/chipper#1510.

If you would like, you can confirm these attributes are there by inspecting in the page.

[pixelzoom]

Understood, thanks. Closing.

[kathy-phet]

Using NVDA, it says whether its "On" and "Off" which is great!