-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
supportsDynamicLocale is automatically on if omitted from the package.json #1005
Comments
With this script, I found this list of sims that need this flag added:
|
Alright. Updates have been committed based on the list from slack. I believe the next step here is to have some sort of QA step where we make sure that we didn't miss any sims that we want to be marked as supportsDynamicLocale:true. Anyone can check if we have marked a sim correctly with a URL like this: https://github.com/phetsims/gravity-and-orbits/blob/main/package.json Here is the current list of repos that have package.json marking them with
|
From dev meeting today. We want to have a good count of dynamic locale sims, but we can't trust the
supportsDynamicLocale
package flag as the number of repos that actually support this.Here is the line we want to default to false if there is no package flag:
https://github.com/phetsims/chipper/blob/a3a64bfe631436dedcfe48944ee663e51ae02265/js/browser/initialize-globals.js#L349-L353
Here is @kathy-phet's list of sims that support dynamic locale:
https://phetsims.slack.com/archives/C05TB6YSP46/p1737384453597939?thread_ts=1737331294.737429&cid=C05TB6YSP46
There are 81 usages of "supportsDynamicLocale": true, this includes common code and test repos.
The text was updated successfully, but these errors were encountered: