-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI sound design #54
Comments
4/9/21 Zoom discussion with @jbphet:
4/12/21 Zoom discussion with @arouinfar:
|
Options: (a) Continue with the plan we established in #48 - Disable "user-interface" category sounds for the 1.0 release, then address sound design in a future release. (ESTIMATE: No additional time.) (b) Ignore the distinction between pedagogical vs non-pedagogical sounds, treat all sounds the same. Enable "user-interface" category sounds for 1.0, let them co-exist with Fourier series sound, don't worry about potential impact on usability or learning goals. (ESTIMATE: 2-4 weeks to get audio balanced, fill in the gaps in common-code sound design.) (c) Continue the discussion about pedagogical vs non-pedagogical sounds, address any UX design and implementation requirements that come out of that, do a full sound design. (ESTIMATE: unknown) Unless the milestones can all be pushed out by 1-? months, I recommend (a). |
4/15/21 design meeting notes: @kathy-phet suggested "ducking" UI sounds when Fourier sounds checkbox is checked, as in Waves Intro. @pixelzoom is wondering if this is something supported by tambo, or is it something specific to Waves Intro. @arouinfar says to look at https://github.com/phetsims/wave-interference/blob/master/js/common/view/WaveMeterNode.js#L225-L227. Amplitude sliders would probably not have a "harmonic" sound, probably just click, click, click (like Waves Intro). We also talked about spinners and specific buttons needing specific sounds. @Kathy would like to do option (b). OK to push milestone out a month or more. Some of @Ashton-Morris's time is available. @jbphet will probably be doing sound implementation for Keypad and other common-code UI components, but that's up for discussion. Next steps:
|
Breaking out sound for amplitude sliders into its own issue, see #56. It looks like that's going to be a significant chunk of work. Sliders appear to be lacking in common-code support for sound. vegas (game) components that need UI sound design are identified in phetsims/vegas#88. |
4/22/21 design meeting @arouinfar @kathy-phet @jbphet @jessegreenberg @pixelzoom
|
I think we can say that we met the 5/15/21 milestone. We investigated what is needed for Fourier sound design, and identified missing pieces. Here's what was identified:
If all of these pieces come together, then Fourier should be in good shape for UI sound. I'll leave this (epic) issue open until the related issues are addressed. |
In #56 (comment), we decided not to add sound for sliders in the 1.0 release. So this issue is done. Closing. |
From 4/13/21 Q2 planning meeting:
Investigate adding UI-component sounds for the 1.0 release.
Milestones:
start = 4/1/21
end = 5/15/21
The text was updated successfully, but these errors were encountered: