Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ?shuffleListeners #205

Open
pixelzoom opened this issue Mar 21, 2023 · 3 comments
Open

support ?shuffleListeners #205

pixelzoom opened this issue Mar 21, 2023 · 3 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Mar 21, 2023

Related to phetsims/axon#215, where @zepumph added a shuffleListeners test to CT.

Short-term work is to investigate where this is failing, and add hasListenerOrderDependencies: true with a TODO comment that references this issue. Long-term work is to eliminate the order dependency, if feasible and cost-effective.

equality-explorer : fuzz : unbuilt : shuffleListeners
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1679397130435/equality-explorer/equality-explorer_en.html?continuousTest=%7B%22test%22%3A%5B%22equality-explorer%22%2C%22fuzz%22%2C%22unbuilt%22%2C%22shuffleListeners%22%5D%2C%22snapshotName%22%3A%22snapshot-1679397130435%22%2C%22timestamp%22%3A1679402863087%7D&brand=phet&ea&fuzz&shuffleListeners&memoryLimit=1000
Query: brand=phet&ea&fuzz&shuffleListeners&memoryLimit=1000
Uncaught Error: Assertion failed: unexpected operand type: VariableTerm: 1/1 Variable: symbol=‪x‬ value=-4
Error: Assertion failed: unexpected operand type: VariableTerm: 1/1 Variable: symbol=‪x‬ value=-4
at window.assertions.assertFunction (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1679397130435/assert/js/assert.js:28:13)
at assert (UniversalOperationControl.ts:210:20)
at callback (Multilink.ts:111:10)
at listener (TinyEmitter.ts:102:8)
at emit (ReadOnlyProperty.ts:312:22)
at _notifyListeners (ReadOnlyProperty.ts:263:13)
at unguardedSet (ReadOnlyProperty.ts:247:11)
at set (Property.ts:65:10)
at set (RectangularRadioButton.ts:139:50)
at listener (TinyEmitter.ts:102:8)
id: Bayes Puppeteer
Snapshot from 3/21/2023, 7:12:10 AM
@pixelzoom pixelzoom self-assigned this Mar 21, 2023
@pixelzoom pixelzoom changed the title CT: fails shuffleListeners test CT: shuffleListeners test is failing Mar 21, 2023
@zepumph
Copy link
Member

zepumph commented Mar 21, 2023

Taking a look now

@zepumph zepumph changed the title CT: shuffleListeners test is failing support ?shuffleListeners Mar 21, 2023
@zepumph
Copy link
Member

zepumph commented Mar 21, 2023

I'm pretty sure that this is the right Property, but CT will tell us for sure. If we still run into it, I will try adding the flag to operandProperty next.

@zepumph
Copy link
Member

zepumph commented Mar 24, 2023

Looking clear on CT this morning. Not closing though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants