Rewards look odd with zoom in/out

[Nancy-Salpepi]

Test device
MacBook Air (m1 chip)

Operating System
12.0.1

Browser
Chrome

Problem description
phetsims/qa#735

If you complete a level of the game while zoomed in, the rewards won't take up the entire screen when you zoom back out.

Steps to reproduce

1. Using rewardScore=1, go to any of the game levels
2. Zoom in
3. Solve for x
4. Zoom out once the rewards have begun to fall

Visuals

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Equality Explorer‬ URL: https://phet-dev.colorado.edu/html/equality-explorer/1.1.0-rc.1/phet/equality-explorer_all_phet.html?showAnswers&gameLevels=1,2 Version: 1.1.0-rc.1 2021-11-09 18:21:34 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/95.0.4638.69 Safari/537.36 Language: en-US Window: 1314x690 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 80) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}

[pixelzoom]

I have no control over this in the sim. RewardNode (common code) automatically adjusts itself when the size of the ScreenView changes, so things work correctly when the browser window is resized. But I'm not familiar with how zoom is implemented, or how it's affecting RewardNode.

@jessegreenberg Can you please have a look at this, suggest what might be causing this, and recommend a fix?

@Nancy-Salpepi Can you please check a few other sims that have rewards, and confirm whether this is a general problem? Please test in master

[Nancy-Salpepi]

@pixelzoom and @jessegreenberg this seems to be a general problem. In Master, I tested Fourier and Fractions Equality and saw the same results.

[pixelzoom]

Thanks @Nancy-Salpepi.

Since it's been established that this is a general problem, I've created phetsims/vegas#97 to investigate, assigned to @jessegreenberg. When we find out what is involved in fixing it, we can decide whether to fix it for Equality Explorer 1.1. In the meatime, this issue is on hold.

[pixelzoom]

@amanda-phet Does this need to be fixed for the 1.1 release?

[amanda-phet]

@pixelzoom this is not a priority for the 1.1 release. When phetsims/vegas#97 gets resolved, I think we can decide how to proceed.

[Edited to clarify] I am not concerned about pan/zoom with the reward node at this time. Since it is not specific to this sim, I don't want to delay publication of EqEx while we wait for a fix.

[pixelzoom]

#176 (comment) sounds like you'd like @jessegreenberg to investigate, then evaluate whether the fix goes into the 1.1 release. Do I understand that correctly @amanda-phet?

My recommendation is that we should punt on this totally for the 1.1 release. While the game enhancements were the motivation for 1.1, this will also be the first version to support pan/zoom. If zoom behaves oddly for the game reward, that’s not a big deal — it’s unlikely to be encountered, and (if it is) it doesn’t break anything or affect learning goals. And there area undoubtedly other published sims that have this problem, so address them all via a batch MR if it's important.

[pixelzoom]

Based on @kathy-phet's comment in phetsims/vegas#97 (comment), this issue will not be addressed for the 1.1 release. Labeling as "deferred", to be addressed in a future release or maintenance release.